New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor user fields in ParticipantInfo + Add custom data docs #841

Merged

DanielNovak merged 1 commit into develop from participant_state

Sep 25, 2023

Contributor

DanielNovak commented Sep 25, 2023 •

edited

Loading

Remove User from ParticipantState. It's not correct to have a User object at this level because we don't have the full data (especially from SFU events) to represent a full user here. Replace it with a userId, name and image. This is also unified with iOS.
Refactor any usage of the User object
Fix issues where we forgot to send custom data (CoordinatorSocket - user.custom data was not being sent)
Add basic docs around custom events

DanielNovak requested a review from a team as a code owner

September 25, 2023 14:22

DanielNovak requested a review from a team

September 25, 2023 14:22

DanielNovak force-pushed the participant_state branch 5 times, most recently from 8461754 to b26b410 Compare

September 25, 2023 15:00


          Refactor user fields in ParticipantInfo + Add custom data docs

DanielNovak force-pushed the participant_state branch from b26b410 to 8303090 Compare

September 25, 2023 15:09

DanielNovak merged commit 6e90fdf into develop

DanielNovak deleted the participant_state branch

September 25, 2023 15:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet