Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotlight view #892

Merged
merged 36 commits into from
Oct 30, 2023
Merged

Spotlight view #892

merged 36 commits into from
Oct 30, 2023

Conversation

aleksandar-apostolov
Copy link
Collaborator

Add a spotlight view.

Allow for the participants layout to switch between layout types.

Three layout types added
Dynamic - if there are pinned participants its spotlight, grid otherwise.
Spotlight - fixed spotlight view, showing the dominant speaker, if there is no dominant speaker, the first one is selected
Grid - As before.

Layout chooser - added in dogfodding invoked via leadingCallContent icon which pops up a dialog to choose the layout.

Additionally modify padding according to the design

…uce clutter in portrait and landscape renderer
…ParticipantGrid to ParticipantLayout and add layout types
@aleksandar-apostolov aleksandar-apostolov marked this pull request as ready for review October 27, 2023 12:09
@aleksandar-apostolov aleksandar-apostolov requested a review from a team October 27, 2023 12:09
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner October 27, 2023 12:09
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks really great. Nicely done! I left several comments especially for docs.

@aleksandar-apostolov
Copy link
Collaborator Author

Also updated minor design feedback into the PR

@aleksandar-apostolov aleksandar-apostolov merged commit bd3ec59 into develop Oct 30, 2023
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the spotlight_view branch October 30, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants