Dismiss direct call notification when call is cancelled #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was also a feature request from RN/Flutter teams I think - but we need to ping the backend devs first because there is no backend support for this yet. I will try to find the thread where we discussed it. |
liviu-timar
force-pushed
the
handle-direct-call-cancellation
branch
from
7a6e9d8 to
66b1b32
Compare
|
Parts of this will be handled in #956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The direct call notification should be dismissed when the call initiator cancels the call.
🛠 Implementation details
Added and handled a new notification type for direct call cancellation.
☑️Reviewer Checklist
🎉 GIF