Modules refactoring #913
Merged
Modules refactoring #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dogfooding/src/main/res/values/strings.xml # stream-video-android-datastore/api/stream-video-android-datastore.api # stream-video-android-model/api/stream-video-android-model.api
DanielNovak
approved these changes
Nov 10, 2023
skydoves
approved these changes
Nov 13, 2023
workspace
added a commit
to workspace/google-meet-clone-compose
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Reduce overall complexity and consolidate modules.
——————
Action:
“stream-video-android-tooling” - merge with dogfooding,
Reason:
Only used there and the code consists of only one debugging activity and a utility function to create “toasts”.
——————
Actions:
“stream-video-android-model” - move into “core” under a model package name.
“stream-video-android-datastore” - move into “core” under a ‘datastore’ package name. If StreamUserDataStore was interface, I would suggest having the interface in core and implementation maybe in separate module.
Reason:
The question I asked to suggest these moves -> Can core be used without datastore / model? If no, then merge the modules. Unless someone wants to use the UI artefacts without the core modules. But current setup doesn’t allow for this.
——————
Actions:
Rename “stream-video-android-xml” to “stream-video-android-ui-xml”
Rename “stream-vdeio-android-compose” to “stream-video-android-ui-compose”
Rename “stream-video-android-ui-common” to “stream-video-android-ui-core”
Reason:
Better clarity on the dependencies between UI modules and what each contains.
——————
Action:
Rename “stream-video-android-mock” to “stream-video-android-ui-previewdata”
Reason:
Only one test uses the “mock” its called BaseComposeTest. The rest usage is into @Preview composable in dogfooding, app and compose modules. Thus the name mock makes no sense.
——————
Action:
“Dogfooding” should became “app” and maybe configure based on flavour if ever.
Reason:
“app” seems to not have reason to exist.
——————