fix: ensure stable sort (#1130)

Ensure Stable Sorting by mutating the source participant array.
GetStream · Oct 5, 2023 · f96e1af · f96e1af
1 parent 465b87e
commit f96e1af
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/client/src/store/CallState.ts b/packages/client/src/store/CallState.ts
@@ -330,8 +330,9 @@ export class CallState {
   constructor() {
     this.logger = getLogger(['CallState']);
     this.participants$ = this.participantsSubject.asObservable().pipe(
-      // TODO: replace with Array.toSorted once available
-      map((ps) => [...ps].sort(this.sortParticipantsBy)),
+      // maintain stable-sort by mutating the participants stored
+      // in the original subject
+      map((ps) => ps.sort(this.sortParticipantsBy)),
       shareReplay({ bufferSize: 1, refCount: true }),
     );
 

diff --git a/packages/client/src/store/__tests__/CallState.test.ts b/packages/client/src/store/__tests__/CallState.test.ts
@@ -69,7 +69,7 @@ describe('CallState', () => {
 
       const ps2 = state.participants;
       // should resolve in initial - non-mutated state as set at the beginning
-      expect(ps2.map((p) => p.name)).toEqual(['A', 'B', 'C', 'D', 'E', 'F']);
+      expect(ps2.map((p) => p.name)).toEqual(['F', 'B', 'E', 'A', 'C', 'D']);
     });
 
     it('should support custom sorting', () => {