feat(react-native): add lobby footer component #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aharwood9
changed the title
santhoshvai
approved these changes
Oct 4, 2023
|
@khushal87 can you check this asap, as the owner of lobby components.. 🙏 |
|
@aharwood9 many thanks for spotting and fixing this |
|
Yes @santhoshvai |
khushal87
approved these changes
Oct 4, 2023
|
Thanks @khushal87 and @santhoshvai 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adding a meeting UI, I found I couldn't customise the text above the button in the Lobby component. As we will be using the channelId for the callId, I didn't like that it said they were joining this seemingly random ID. This would likely be confusing to the user as they have no reference to this.
Changes -
Tested -
Note - I've also updated the translation as there was a random capital "J" in join. I can revert if this was intentional.