feat(react-native): add landscape mode support to Lobby, RingingCallContent and DF app #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
changed the title
santhoshvai
reviewed
Oct 12, 2023
| }: IncomingCallProps) => { | ||
| const { t } = useI18n(); | ||
| const { | ||
| theme: { colors, incomingCall, typefaces }, | ||
| } = useTheme(); | ||
|
|
||
| const landScapeContentStyles: ViewStyle = { |
There was a problem hiding this comment.
Suggested change
| const landScapeContentStyles: ViewStyle = { | |
| const landscapeContentStyles: ViewStyle = { |
santhoshvai
reviewed
Oct 12, 2023
| @@ -71,12 +74,16 @@ const JoinCallScreen = () => { | |||
| } | |||
| }; | |||
|
|
|||
| const landScapeStyles: ViewStyle = { | |||
There was a problem hiding this comment.
Suggested change
| const landScapeStyles: ViewStyle = { | |
| const landscapeStyles: ViewStyle = { |
santhoshvai
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for landscape mode temporarily for Lobby and RingingCall components so that it doesn't overflow when rendered alongside other components.
SDK components:
DF app screens:
