Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): ESM and CJS bundles #1144

Merged
merged 16 commits into from
Oct 18, 2023
Merged

feat(build): ESM and CJS bundles #1144

merged 16 commits into from
Oct 18, 2023

Conversation

oliverlaz
Copy link
Member

@oliverlaz oliverlaz commented Oct 13, 2023

Overview

  • provide ESM and CJS bundles for all of our packages and use ES2020 as a base line
  • upgrade relevant dependencies to their latest versions
  • TypeScript adjustments
  • Merges @stream-io/i18n to @stream-io/video-react-bindings
  • Replaces our custom copy-version script with a solution built on top of rollup

Fixes: #1025

TODO:

  • Test React Sample Apps
  • Test React Native Sample Apps
  • Test Plain-JS Sample Apps

- provide ESM and CJS bundles for all of our packages
- upgrade relevant dependencies to their latest versions
- TypeScript adjustments
Copy link
Member

@khushal87 khushal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the issues reported on Slack, everything seems to be fine from the RN side.

@oliverlaz oliverlaz merged commit 58b60ee into main Oct 18, 2023
17 of 19 checks passed
@oliverlaz oliverlaz deleted the bundling branch October 18, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: Cannot use import statement outside a module on NextJS13 using Pages Router
3 participants