-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-sdk)!: Visual redesign of the SDK and Demo App #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-video-js into feature/WD-1079
- add video device selection button - add mic device selection button
…-video-js into feature/WD-1079
- style documentation buttons smaller
oliverlaz
added a commit
that referenced
this pull request
Dec 1, 2023
As we are preparing to roll out a redesigned Pronto / Dogfood app for internal purposes, we'd like to keep the existing app as a backup. For that purpose, we've created a new project on Vercel (`stream-calls-dogfood-legacy`) that will host the current version and design of Pronto. Soon, the existing domains `https://pronto.getstream.io` and `https://stream-calls-dogfood.vercel.app` will point to instances built from the following branch #1194 (and `main` once the linked PR is merged). The legacy version will be available here: `https://stream-calls-dogfood-legacy.vercel.app`
Assign `data-testid` attributes to the Call Control Buttons.
- allow for a primary and secondary active state on the button
Adds an experimental waiting room functionality in Pronto built on top of `custom` events. For more information, check: https://getstream.slack.com/archives/C022N8JNQGZ/p1706886559355909thread_ts=1706212004.817829&cid=C022N8JNQGZ
# Conflicts: # packages/react-sdk/CHANGELOG.md # yarn.lock
oliverlaz
changed the title
feat(react-sdk): Visual redesign of the SDK and Demo App
feat!(react-sdk): Visual redesign of the SDK and Demo App
Feb 23, 2024
oliverlaz
changed the title
feat!(react-sdk): Visual redesign of the SDK and Demo App
feat(react-sdk)!: Visual redesign of the SDK and Demo App
Feb 23, 2024
oliverlaz
approved these changes
Feb 26, 2024
oliverlaz
added a commit
that referenced
this pull request
Feb 27, 2024
As part of #1194, this application was merged with the one we use for internal testing (react-dogfood). As we don't want to maintain this codebase anymore, this PR removes the app's code. We know some customers might have looked into it and that is why the `react-video-demo` directory stays in the React sample apps. The Readme is updated with a hint to look at the React Dogfood app instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the new styling for our SDK-provided components.
Changes
Styling
Components
Button
CompositeButton.tsx
ToggleMenuButton
prop has been added by defaultDefaultToggleMenuButton
primary
andsecondary
to indicate a primary and secondary active state of the buttonactive
class has been added to theDefaultToggleMenuButton
.Call controls
CancelCallButton.tsx
ToggleAudioButton.tsx
ToggleVideoButton.tsx
ReactionsButton.tsx
horizontal
orvertical
defaults tohorizontal
RecordCallButton.tsx
Other
CallParticipantsList.tsx
CallRecordingListHeader
CallStats.tsx
lowBound
(default 75) and ahighBound
(default 400) prop to indicate what you think is an acceptable latency.DropdownSelect.tsx
Icon.tsx
MenuToggle.tsx
portal
ormenu
to display the MenuToggle.Notification.tsx
close
prop so a notification can be closed by the userRecordingInProgressNotification.tsx
DefaultVideoPlaceholder