fix(client): receive audioLevels when joined the call with mic muted #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
requested review from
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
khushal87
changed the title
|
if we have |
santhoshvai
approved these changes
Nov 28, 2023
szuperaz
reviewed
Nov 28, 2023
szuperaz
reviewed
Nov 28, 2023
| const defaultConstraints = this.state.defaultConstraints; | ||
| const constraints: MediaTrackConstraints = { | ||
| ...defaultConstraints, | ||
| deviceId: this.state.selectedDevice, | ||
| }; | ||
| stream = await this.getStream(constraints as C); | ||
| this.state.setMediaStream(stream); | ||
| await this.muteOrDestroyStream(this.state.disableMode === 'stop-tracks'); |
There was a problem hiding this comment.
Suggested change
| await this.muteOrDestroyStream(this.state.disableMode === 'stop-tracks'); | |
| await this.muteOrDestroyStream(false); |
We always want to just mute the stream here, if we call it with stop-tracks we destroy the stream that we've just created
| stream = this.state.mediaStream; | ||
| this.unmuteTracks(); | ||
| } else { | ||
| if (!this.state.mediaStream && settings && settings.createMutedStream) { |
There was a problem hiding this comment.
I think we can do this with less copy-paste, and we can remove this whole if statement, see below
| ...defaultConstraints, | ||
| deviceId: this.state.selectedDevice, | ||
| }; | ||
| stream = await this.getStream(constraints as C); |
There was a problem hiding this comment.
Check here if we need to mute
if (settings && settings.createMutedStream) {
await this.muteOrDestroyStream(false);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client Changes:
muteStreamAPI is changed now tomuteOrDestroyStream.unmuteStreamAPI is changed tounmuteOrCreateStream.disableTrackWhilePublishargument that will not enable the track while publish, which currently happens every time here.