-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fast Reconnection #1212
Merged
Merged
feat: Fast Reconnection #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
santhoshvai,
szuperaz,
vishalnarkhede,
MartinCupela,
khushal87 and
arnautov-anton
December 4, 2023 16:50
szuperaz
approved these changes
Dec 7, 2023
oliverlaz
added a commit
that referenced
this pull request
Dec 15, 2023
Implements Fast Reconnection flow. This should significantly speed up the call drop recovery caused by a network switch. ### Implementation notes In case the WebSocket connection interrupts (due to a network switch WiFi -> 5G, or anything else), we'll attempt to re-establish a connection to the existing SFU by reusing the existing credentials and configuration. When this fails, we will attempt a Full Reconnect, and involve the Coordinator in the picture, as we do it today.
oliverlaz
added a commit
that referenced
this pull request
Dec 22, 2023
Implements Fast Reconnection flow. This should significantly speed up the call drop recovery caused by a network switch. ### Implementation notes In case the WebSocket connection interrupts (due to a network switch WiFi -> 5G, or anything else), we'll attempt to re-establish a connection to the existing SFU by reusing the existing credentials and configuration. When this fails, we will attempt a Full Reconnect, and involve the Coordinator in the picture, as we do it today. ### Notes This PR is a rebase of #1212 against `main`.
oliverlaz
added a commit
that referenced
this pull request
Jan 16, 2024
Fixes a regression introduced with #1212 where the status of the underlying SFU WebSocket was incorrectly checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements Fast Reconnection flow. This should significantly speed-up the call drop recovery caused by a network switch.
Implementation notes
In case the WebSocket connection interrupts (due to a network switch WiFi -> 5G, or anything else), we'll attempt to re-establish a connection to the existing SFU by reusing the existing credentials and configuration. When this fails, we will attempt a Full Reconnect, and involve the Coordinator in the picture, as we do it today.