fix(ringing): Auto-Cancel outgoing calls #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
santhoshvai,
szuperaz,
vishalnarkhede,
MartinCupela,
khushal87 and
arnautov-anton
szuperaz
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
@oliverlaz does this mean that incoming_call_timeout_ms will be removed from BE? I couldn't find that info in the linked Slack conversation
@szuperaz, I'm not sure when this is going to happen, as this is a breaking change. But, if we keep using the two values, we may run into a weird situation. |
santhoshvai
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug in the
scheduleAutoDrop()function that bailed out from scheduling a cancellation timer when server-side defined timeouts remained the same after consecutive call settings updates.Also, this PR aligns the implementation and relies only on
auto_cancel_timeout_ms. More context:Fixes: #1215