fix(design-v2): color consolidation and other fixes #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristian-mkd
changed the base branch from
main
to
PBE-5855-feat/react-native-video-design-v2
…nd other minor fixes
…consolidation-and-other-fixes
kristian-mkd
requested review from
santhoshvai,
oliverlaz,
isekovanic and
khushal87
…consolidation-and-other-fixes
santhoshvai
reviewed
Nov 11, 2024
Comment on lines
10
to
12
| export const Mic = ({ color, size }: Props) => ( | ||
| <Svg viewBox={`0 0 ${size} ${size}`} width={size} height={size}> | ||
| <Svg viewBox={'0 0 27 27'} width={size} height={size}> | ||
| <Path |
There was a problem hiding this comment.
why change this?? I dont get it
There was a problem hiding this comment.
size will not be changeable then
There was a problem hiding this comment.
I noticed that best way to adjust the icon size without distortion is through dynamic width={size} height={size}, and keeping the viewBox with the fixed dimensions as it was exported from Figma.
…consolidation-and-other-fixes
kristian-mkd
merged commit 187f2e4
into
PBE-5855-feat/react-native-video-design-v2
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
FLOATING_VIDEO_VIEW_STYLEwidth and height to bigger values according to new design-v2LOBBY_VIDEO_VIEW_HEIGHTScreenshots