fix: unhandled promise rejections during reconnect #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
Nov 21, 2024
| this.disconnectionPromise = this.connectionPromise | ||
| ? this.connectionPromise.then(() => disconnectUser()) | ||
| : disconnectUser(); | ||
| this.disconnectionPromise.finally( | ||
| () => (this.disconnectionPromise = undefined), | ||
| await withoutConcurrency(this.connectionConcurrencyTag, () => | ||
| disconnectUser(), |
There was a problem hiding this comment.
We had a lot of this disconnectionPromise/connectionPromise chaining to make sure the two don't run at the same time. Replacing with withoutConcurrency for simplicity. Also allows us to get rid of two stored promises.
oliverlaz
reviewed
Nov 21, 2024
myandrienko
force-pushed
the
reconnect-handle-errors
branch
from
67f895a to
f852c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of where unhandled rejections are coming from, see https://github.com/GetStream/stream-video-js/pull/1585/files#diff-420f6ddab47c1be72fd9ce8c99e1fa2b9f5f0495b7c367546ee0ff634beaed81