Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple rare ringing issues in react-native #1611

Merged
merged 17 commits into from
Dec 13, 2024

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Dec 4, 2024

  1. When permission was denied in RN. It was not properly handled.

Now after this change, if permissions are not granted in RN, our client properly logs like below

ERROR: [devices]: Failed to get audio stream {"constraints": {"audio": {"autoGainControl": true, "deviceId": undefined, "echoCancellation": true, "noiseSuppression": true}}, "error": {"constraintName": undefined, "message": "Permission denied.", "name": "SecurityError"}}
 ERROR: [permissions]: Failed to getUserMedia {"error": {"constraintName": undefined, "message": "Permission denied.", "name": "SecurityError"}, "permission": {"constraints": {"video": [Object]}, "queryName": "camera"}}
  1. DOMException is not present in RN, so must check for it

  2. Foreground notification can rarely make app go to PiP automatically, fixed in this

  3. hot reloads could add multiple listeners, causing push to be processed twice.. fixed here

  4. App going to background, could disable unnecessarily, fixed here

  5. Removed the camera handling in incmoing call component to fix race on foreground notification

  6. updated the firebase setup with both samples inside stream-video project

  7. Apply importance: 4 to ringing notifications, support request.. channel was already set to this, so doesnt change anything actually

@santhoshvai santhoshvai changed the title fix: permission prompt should not be called in RN fix: crash and loops in RN when device permission is denied Dec 5, 2024
@santhoshvai santhoshvai changed the title fix: crash and loops in RN when device permission is denied fix: crash and loop in RN when device permission is denied Dec 5, 2024
@santhoshvai santhoshvai changed the title fix: crash and loop in RN when device permission is denied fix: multiple ringing issues in react-native Dec 12, 2024
@santhoshvai santhoshvai changed the title fix: multiple ringing issues in react-native fix: multiple rare ringing issues in react-native Dec 12, 2024
@santhoshvai santhoshvai merged commit 4e25264 into main Dec 13, 2024
18 of 19 checks passed
@santhoshvai santhoshvai deleted the fix-rn-permission-issues branch December 13, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants