fix: adjust dynascale debouncing for upscaling and downscaling #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
Dec 12, 2024
Comment on lines
429
to
433
| // the participant just started to publish a track | ||
| requestTrackWithDimensions(DebounceType.FAST, { | ||
| requestTrackWithDimensions(DebounceType.IMMEDIATE, { | ||
| width: videoElement.clientWidth, | ||
| height: videoElement.clientHeight, | ||
| }); |
There was a problem hiding this comment.
For this case (subscribing after a participant started to publish video), do we even need debouncing? I think it would be nice to just subscribe immediately. But for now, I've just set minimal debouncing timeout here.
oliverlaz
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently debounce requests to update participant subscriptions when a bound video element size changes with a delay of 1200ms. That's too long of delay, but there are also other considerations.
Not all size changes are equal: when upscaling, low quality video in a larger video element is very noticeable; high quality video in a smaller video element for a second or two is not a big deal.
Proposal: