fix(virtual): incorrect import path #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p#1634) * feat(alias): add warning to avoid unintended duplicate modules * test: normalize slash * test: normalize slash correctly * test: return promise
…d as warning (rollup#1625) * allow no files error to be emitted as warning * Update packages/dynamic-import-vars/README.md Co-authored-by: Andrew Powell <[email protected]> --------- Co-authored-by: Andrew Powell <[email protected]>
…ollup#1635) * feat(pluginutils): add `namedExports: 'include-arbitrary-name'` to `dataToEsm` * refactor(pluginutils): change to includeArbitraryNames * docs: add options to dataToEsm section * docs: add option description to new option --------- Co-authored-by: Andrew Powell <[email protected]>
docs: consistent plugin names
Co-authored-by: Andrei Picus <[email protected]>
* fix: update regex to do not match new line in specifier group * test: add testcases and update snapshot
9 tasks
|
Probably obsolete, i now created a separate PR in the rollup repo because i think my fix should be done anyway, independently from your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix building for your PR... unfortunately i can just guess what the build problem was, as the logs for the failed builds are no longer available. After i checked out your fork, i noticed an incorrect import path in the "virtual" plugin which i think caused the build to fail. This import weirdly was accepted until you removed the
typesproperty in thepackage.jsonwith your commit here. All other plugins seem to import their types from"../types"as well (e.g. alias, so i don't see a reason why it should be different for the "virtual" plugin...