Fix #5162

GeyserMC · Nov 24, 2024 · 5250915 · 5250915
1 parent 2ebce9c
commit 5250915
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/...c/main/java/org/geysermc/geyser/translator/protocol/java/JavaRecipeBookAddTranslator.java b/...c/main/java/org/geysermc/geyser/translator/protocol/java/JavaRecipeBookAddTranslator.java
@@ -185,8 +185,13 @@ public void translate(GeyserSession session, ClientboundRecipeBookAddPacket pack
             }
         }
 
-        session.sendUpstreamPacket(craftingDataPacket);
-        session.sendUpstreamPacket(recipesPacket);
+        if (!recipesPacket.getUnlockedRecipes().isEmpty()) {
+            // Sending an empty list here will crash the client as of 1.20.60
+            // This was definitely in the codebase the entire time and did not
+            // accidentally get refactored out during Java 1.21.3. :)
+            session.sendUpstreamPacket(craftingDataPacket);
+            session.sendUpstreamPacket(recipesPacket);
+        }
         session.getLastRecipeNetId().set(netId);
 
         // Multi-version can mean different Bedrock item IDs