Fix for plugins that use display entities as nametag #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtm516
requested changes
Nov 21, 2024
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Outdated
Show resolved
Hide resolved
| Vector3f displayTranslation = textDisplay.getTranslation(); | ||
| if (displayTranslation != null && textDisplay.getText() != null) { | ||
| int lines = PlainTextComponentSerializer.plainText().serialize(textDisplay.getText()).split("\n").length; | ||
| float multiplier = (float) Math.max(0.22f, 0.45f - (0.06f * Math.floor((lines - 4) / 2f))); |
There was a problem hiding this comment.
Can we get some info on what all these numbers are?
There was a problem hiding this comment.
I did some tests with multiple lines, then I gave an ai those tests and it gave me a function that follows a pattern based on the number of lines
There was a problem hiding this comment.
Can we get this info verified?
And I think that it'd also be nice that we assert the behaviour by adding some tests for it
Removed useless offset
onebeastchris
previously requested changes
Nov 21, 2024
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Show resolved
Hide resolved
rtm516
requested changes
Nov 22, 2024
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/entity/type/TextDisplayEntity.java
Outdated
Show resolved
Hide resolved
|
Is there something else you want me to change? I'd like to push an update for my plugin that adds support for bedrock but I'm waiting for this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a simple formula that calculates y offset based on the lines the display entity has. It's not perfect for higher values but for values up to 4/5 is close to vanilla.