Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some shapes are broken after merge of #49 #62

Closed
1 of 6 tasks
Firigion opened this issue Mar 20, 2021 · 2 comments · Fixed by #97
Closed
1 of 6 tasks

Some shapes are broken after merge of #49 #62

Firigion opened this issue Mar 20, 2021 · 2 comments · Fixed by #97
Assignees
@Ghoulboy78
Labels
bug Something isn't working waiting for release Waiting for a Carpet release
Milestone
v1.4.0

Comments

@Firigion
Copy link
Collaborator

Firigion commented Mar 20, 2021 •
edited
Loading

  • Cylinder, Cone and Pyramid with special orientations don't work at all (they don't place blocks)
  • Cone creates pyramids, and pyramids have uneven slopes (here you can see 3 blocks at the bottom and the steps of one, instead of the expected two steps of two):

  • Hollow ellipsoid has holes:

  • Hollow cuboid has strange shape:

  • Hollow cube is very broken:

  • Shpere is not isotropic (symmetrical):

Don't fix what ain't broke, and if you do, make sure the fix works...
@altrisi altrisi added the bug Something isn't working label Mar 21, 2021
@Ghoulboy78
Copy link
Owner

I think most of these can be fixed when I rewrite them after gnembon/fabric-carpet#742 is accepted.

@Ghoulboy78
Copy link
Owner

except for ellipsoid, which is borked differently, but I think I can fix that aswell

@Firigion Firigion added this to the v1.3.0 milestone Mar 23, 2021
@Ghoulboy78 Ghoulboy78 self-assigned this Mar 30, 2021
@Ghoulboy78 Ghoulboy78 added the waiting for release Waiting for a Carpet release label Mar 31, 2021
@Ghoulboy78 Ghoulboy78 modified the milestones: v1.3.0, v1.4.0 Jun 27, 2021
@Firigion Firigion mentioned this issue Jul 8, 2021
Draft
@Ghoulboy78 Ghoulboy78 linked a pull request Dec 31, 2021 that will close this issue
Updating shapes to use shapes.scl and fix some minor things #94
Open
@Firigion Firigion removed a link to a pull request Jan 7, 2022
Updating shapes to use shapes.scl and fix some minor things #94
Open
@Firigion Firigion linked a pull request Jan 7, 2022 that will close this issue
Re-adding working shapes plus some new ones #97
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ghoulboy78 Ghoulboy78

Labels
bug Something isn't working waiting for release Waiting for a Carpet release
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Re-adding working shapes plus some new ones Ghoulboy78/Scarpet-edit
3 participants
@altrisi @Ghoulboy78 @Firigion