-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-adding working shapes plus some new ones #97
Conversation
Wait, I see you've added a bunch of new functions. Do you intend on keeping them even after I implement the new shapes from |
I'll add comments. Some functions are staying, since they are used in shapes that are not gonne be replaced. And I'd discuss the replacement of some of the rhapes anyway, I wrote some decent code this time. We'll have to test efficiencies once the library is finished. Right now, diamond can't get much better, I'm pretty sure, I do absolutely no extra check, just calculate the blocks needed in the most straightforward way, i even minimized the ammount of divisions needed. Pyramid is quite good too, for the same reason. Cone and cylinder could use a better circle algorithm, right now for a circle with radius Only case where an improvement would actually impact the performance is in hollow cone, since making the case where Shperes and eliposids I didn't touch and those are really bad. They check |
I re-introduced the old shapes implementations to ahve a version to ship with the next release until #94 is done. Also:
CONTRIBUTING.md
while at it.Should we add a link to the discor dserver/channel in either readme, the docs or the contribution manual?