-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spray paint and reintroduce #45 #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghoulboy78
reviewed
Feb 13, 2021
Ghoulboy78
reviewed
Feb 13, 2021
Ghoulboy78
reviewed
Mar 20, 2021
Ghoulboy78
reviewed
Mar 20, 2021
world-edit.sc
Outdated
}, | ||
} | ||
'feature'->{'type'->'term','options'-> get_features_list()}, | ||
'brush'->{'type'->'term', 'suggester'->_(ignored)->keys(global_brushes)}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y indent like that?
Ghoulboy78
reviewed
Mar 20, 2021
Ghoulboy78
approved these changes
Mar 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, this looks good now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the spray paint brush, with a bunch of algebra functions it needs. Maybe those should be abstracted to a library, like
math.scl
, but that's for another discussion.I also reintroduced the changes in #45 that had been accidentally erased when merging, and further improved on the
brush info
command by structuring the parameters of the brush in a nicer way. There was a small bug with one of the old selection functions that was unreported, I fixed that one as well.@Ghoulboy78 we'll need to be careful when merging this with #49, because brushes now require some extra stuff to have their info properly displayed (namely, a list of parameters added to
global_brushes_parameters_map
). Depending on which PR is merged first, the other one will have to add that toCONTRIBUTE.md
. If the data is not added for a new brush, info will default to a less verbose and informative version, but it will still work, so it's not such a big deal. Same goes for #51, which will have to be updated to the new brush format once merged.