Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spray paint and reintroduce #45 #52

Merged
merged 19 commits into from
Mar 20, 2021
Merged

Spray paint and reintroduce #45 #52

merged 19 commits into from
Mar 20, 2021

Conversation

Firigion
Copy link
Collaborator

@Firigion Firigion commented Feb 5, 2021

I added the spray paint brush, with a bunch of algebra functions it needs. Maybe those should be abstracted to a library, like math.scl, but that's for another discussion.

I also reintroduced the changes in #45 that had been accidentally erased when merging, and further improved on the brush info command by structuring the parameters of the brush in a nicer way. There was a small bug with one of the old selection functions that was unreported, I fixed that one as well.

@Ghoulboy78 we'll need to be careful when merging this with #49, because brushes now require some extra stuff to have their info properly displayed (namely, a list of parameters added to global_brushes_parameters_map). Depending on which PR is merged first, the other one will have to add that to CONTRIBUTE.md. If the data is not added for a new brush, info will default to a less verbose and informative version, but it will still work, so it's not such a big deal. Same goes for #51, which will have to be updated to the new brush format once merged.

This was referenced Feb 10, 2021
world-edit.sc Outdated Show resolved Hide resolved
world-edit.sc Outdated Show resolved Hide resolved
docs/Documentation.md Outdated Show resolved Hide resolved
world-edit.sc Outdated
},
}
'feature'->{'type'->'term','options'-> get_features_list()},
'brush'->{'type'->'term', 'suggester'->_(ignored)->keys(global_brushes)},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y indent like that?

Copy link
Owner

@Ghoulboy78 Ghoulboy78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this looks good now!

@Ghoulboy78 Ghoulboy78 merged commit c43cd8f into master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants