-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete field from target when not in source #10
Conversation
Added the same feature that was added to the
|
Do we need the deleteMissing flag? I understand that it preserves the existing behavior but Im not sure that's good thing - I cant think of a use case where you would want the last stale value left in the target when the field gets deleted in the source let alone making this the default behavior. I believe this warrants a breaking change - and and major version number increase |
Want to update the version no. is this PR? |
Yeah sure. I was going to do it in #4 |
From issue #8, the new feature deletes a field in the target collection docs, the deleteMissing flag defaults to false. Field needs to be in the attribute mapping to be removed for example:
if the after snapshot is (master):
The
foreignDetail2
will be deleted from the target snapshot asmasterDetail2
is not there and maps toforeignDetail2