Merge pull request #613 from Giveth/f_612_server_should_not_return_st…

…ack_error

Don't return stack errors to client

src/app.hooks.js

@@ -58,7 +58,7 @@ const convertVerifiedToBoolean = () => context => {
   return context;
 };
 
-const changeMongoErrors = () => context => {
+const parseErrors = () => context => {
   // verified field is boolean in Trace, Campaign and Community so for getting this filter
   // in query string we should cast it to boolean here
   if (context.error.message.includes('Invalid query parameter')) {
@@ -69,6 +69,11 @@ const changeMongoErrors = () => context => {
     logger.info('Mongo error in feathers call', context.error);
     throw new errors.BadRequest(errorMessages.INVALID_INPUT_DATA);
   }
+  if (context.error.stack && context.error.type !== 'FeathersError') {
+    // Should not return stack error to client when error is not instance of Feathers error
+    logger.info('Error with stack', context.error);
+    throw new errors.GeneralError();
+  }
   return context;
 };
 
@@ -123,7 +128,7 @@ module.exports = {
   },
 
   error: {
-    all: [responseLoggerHook(), changeMongoErrors()],
+    all: [responseLoggerHook(), parseErrors()],
     find: [],
     get: [],
     create: [],