Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with NumPy 1.25 #382

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Update with NumPy 1.25 #382

merged 6 commits into from
Aug 8, 2023

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Aug 8, 2023 •
edited
Loading

In short:

  • Replacing np.find_common_dtypes that is deprecated: to get the same behaviour, now using np.promote_dtypes in a try/except to catch promotion errors with datetimes and return an object dtype (see https://numpy.org/devdocs/release/1.25.0-notes.html#deprecations),
  • Ignoring int64 and uint64 casting rules in ufunc tests, which were recently added.

Resolves #381

@rhugonnet rhugonnet merged commit 2f3a547 into GlacioHack:main Aug 8, 2023
10 checks passed
@rhugonnet rhugonnet deleted the numpy_1.25 branch August 8, 2023 22:29
adehecq
adehecq reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehecq adehecq adehecq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix issues arising with NumPy 1.25
2 participants
@rhugonnet @adehecq