Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matchit functionality #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix matchit functionality #5

wants to merge 1 commit into from

Conversation

icook
Copy link

@icook icook commented Jul 7, 2013

This is an old file plugin that I managed to dig up that makes matchit work for Jinaj2 templates. There's probably some un-needed stuff in there, but it hasn't broken anything for me.

@aidos
Copy link

aidos commented Nov 3, 2014

This is extremely useful. Would be great if it could be merged into the main project. For the moment I'm going to switch to icook's repo to get this behaviour..

@ypid
Copy link

ypid commented Feb 15, 2015

👍

But I had some problems with matching the following:

{% if (apt is defined and apt) and apt != True %}
Acquire::http::Proxy "http://{{ apt }}:{{ apt_acng_port | default('3142') }}/";
Acquire::https::Proxy "false";
{% endif %}

So I am using the fork from chase who found a fix for this.

@ernstki
Copy link

ernstki commented Jun 15, 2022

@icook Was this PR meant to enable % matching on Jinja control flow like {% if … %} and {% for … %}, or just to get % working for HTML tags again?

If the latter, I think #19 already addressed % for HTML tags (works for me with the latest master anyway), in which case this PR could be closed.

@icook
Copy link
Author

icook commented Jun 15, 2022

@ernstki Hard to remember honestly, but by my read it was specifically for Jinja2. The aforementioned fork from chase sounds like a more robust solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants