Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to latest versions of AWS addons and AMI #142

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Sep 6, 2024

PR Type

enhancement, documentation


Description

  • Updated AWS EKS addon versions in test configuration and documentation to latest versions.
  • Updated csi_driver_version, coredns_version, and kube_proxy_version to ensure compatibility with EKS version 1.28.
  • Updated ami_release_version in commented node pool configurations across multiple files.

Changes walkthrough 📝

Relevant files
Enhancement
main.tf
Update AWS EKS addon versions in test configuration           

tests/main.tf

  • Updated csi_driver_version to v1.34.0-eksbuild.1.
  • Updated coredns_version to v1.10.1-eksbuild.13.
  • Updated kube_proxy_version to v1.28.12-eksbuild.2.
  • Updated ami_release_version in commented node pool configurations.
  • +6/-6     
    Documentation
    README.md
    Update AWS EKS addon versions in README example                   

    README.md

  • Updated csi_driver_version to v1.34.0-eksbuild.1.
  • Updated coredns_version to v1.10.1-eksbuild.13.
  • Updated kube_proxy_version to v1.28.12-eksbuild.2.
  • Updated ami_release_version in commented node pool configurations.
  • +6/-6     
    .header.md
    Update AMI release version in documentation header             

    docs/.header.md

  • Updated ami_release_version in commented node pool configurations.
  • +3/-3     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @codiumai-pr-agent-free codiumai-pr-agent-free bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 6, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Version Compatibility
    Ensure that the updated AWS EKS addon versions are compatible with EKS version 1.28 and with each other.

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Use a specific version tag in the source URL for better version control

    Update the source URL to use a specific version tag instead of the main branch. This
    ensures reproducibility and prevents unexpected changes when the repository is
    updated.

    README.md [19]

    -source             = "git::https://github.com/GlueOps/terraform-module-cloud-aws-kubernetes-cluster.git"
    +source             = "git::https://github.com/GlueOps/terraform-module-cloud-aws-kubernetes-cluster.git?ref=v1.0.0"
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Using a specific version tag in the source URL is a best practice that enhances reproducibility and stability by preventing unexpected changes from upstream updates.

    8
    Maintainability
    Add a comment to explain the version updates of AWS addons

    Consider adding a comment explaining the reason for updating the versions of
    csi_driver, coredns, and kube_proxy. This can help future maintainers understand the
    motivation behind these changes.

    tests/main.tf [5-7]

    +# Updated AWS addon versions to latest compatible with EKS 1.28
     csi_driver_version = "v1.34.0-eksbuild.1"
     coredns_version    = "v1.10.1-eksbuild.13"
     kube_proxy_version = "v1.28.12-eksbuild.2"
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding a comment to explain the version updates improves maintainability by providing context for future maintainers, but it is not crucial for functionality.

    7

    Copy link

    sonarqubecloud bot commented Sep 6, 2024

    @venkatamutyala venkatamutyala merged commit 4bd1b9f into main Sep 6, 2024
    5 of 6 checks passed
    @venkatamutyala venkatamutyala deleted the feat/updates branch September 6, 2024 03:24
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants