Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws-cloud-regression-suite.yml #174

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Oct 15, 2024

PR Type

configuration changes


Description

  • Added a workflow_dispatch trigger to the AWS Regression Suite workflow to enable manual execution of the workflow.
  • Corrected the placement of the workflow_dispatch trigger by removing it from under the concurrency section.

Changes walkthrough 📝

Relevant files
Configuration changes
aws-cloud-regression-suite.yml
Add manual trigger and fix workflow configuration               

.github/workflows/aws-cloud-regression-suite.yml

  • Added workflow_dispatch trigger to allow manual workflow runs.
  • Removed misplaced workflow_dispatch under concurrency.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Workflow Trigger
    Verify that adding the workflow_dispatch trigger doesn't interfere with the existing pull_request trigger and that both triggers function as intended.

    @venkatamutyala venkatamutyala changed the title Update aws-cloud-regression-suite.yml fix: aws-cloud-regression-suite.yml Oct 15, 2024
    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Add customizable inputs for manual workflow triggers to increase flexibility

    Consider adding environment variables or inputs for the workflow_dispatch event to
    allow customization when manually triggering the workflow.

    .github/workflows/aws-cloud-regression-suite.yml [3-6]

     on:
       pull_request:
         types: [opened, synchronize, reopened]
       workflow_dispatch:
    +    inputs:
    +      environment:
    +        description: 'Environment to run tests against'
    +        required: true
    +        default: 'staging'
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Introducing inputs for the workflow_dispatch event enhances flexibility by allowing users to customize the workflow when triggered manually. This is a valuable improvement, increasing the utility of the manual trigger.

    8
    Specify target branches for the pull request trigger to optimize workflow execution

    Consider adding a branches filter to the pull_request trigger to specify which
    branches should trigger the workflow. This can help reduce unnecessary workflow
    runs.

    .github/workflows/aws-cloud-regression-suite.yml [3-6]

     on:
       pull_request:
         types: [opened, synchronize, reopened]
    +    branches: [main, develop]
       workflow_dispatch:
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding a branches filter to the pull_request trigger can help optimize workflow execution by reducing unnecessary runs. This suggestion is relevant and can improve the efficiency of the workflow.

    7

    💡 Need additional feedback ? start a PR chat

    @venkatamutyala venkatamutyala merged commit 9bac419 into main Oct 22, 2024
    5 of 6 checks passed
    @venkatamutyala venkatamutyala deleted the venkatamutyala-patch-1 branch October 22, 2024 17:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants