Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update eks ami #176

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Feat/update eks ami #176

merged 2 commits into from
Oct 23, 2024

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Oct 22, 2024

PR Type

enhancement, documentation


Description

  • Updated the EKS CSI driver version to v1.36.0-eksbuild.1 across multiple files.
  • Updated the AMI release version to 1.28.13-20241011 in commented sections.
  • Updated documentation to reflect the new versions of the CSI driver and AMI release.

Changes walkthrough 📝

Relevant files
Enhancement
main.tf
Update EKS CSI driver and AMI release versions                     

tests/main.tf

  • Updated csi_driver_version to v1.36.0-eksbuild.1.
  • Updated ami_release_version to 1.28.13-20241011 in comments.
  • +4/-4     
    variables.tf
    Update default CSI driver version                                               

    variables.tf

    • Updated default csi_driver_version to v1.36.0-eksbuild.1.
    +1/-1     
    Documentation
    README.md
    Update documentation for EKS versions                                       

    README.md

  • Updated csi_driver_version to v1.36.0-eksbuild.1.
  • Updated ami_release_version to 1.28.13-20241011 in comments.
  • +5/-5     
    .header.md
    Update header documentation for EKS versions                         

    docs/.header.md

  • Updated csi_driver_version to v1.36.0-eksbuild.1.
  • Updated ami_release_version to 1.28.13-20241011 in comments.
  • +4/-4     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    @codiumai-pr-agent-free codiumai-pr-agent-free bot added documentation Improvements or additions to documentation Review effort [1-5]: 2 labels Oct 22, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Consistency
    Ensure that the updated CSI driver version is compatible with the existing EKS version and other components.

    Default Value Update
    Verify that the new default CSI driver version is appropriate and doesn't introduce compatibility issues.

    Documentation Update
    Confirm that all references to CSI driver version and AMI release version are consistently updated throughout the documentation.

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Synchronize CoreDNS and kube-proxy versions across the module files

    Update the coredns_version and kube_proxy_version variables to match the latest
    versions used in the tests/main.tf file for consistency across the module.

    variables.tf [12]

     variable "coredns_version" {
       type        = string
    -  default     = "v1.10.1-eksbuild.11"
    +  default     = "v1.10.1-eksbuild.13"
       description = "You should grab the appropriate version number from: https://docs.aws.amazon.com/eks/latest/userguide/managing-coredns.html"
     }
     
     variable "kube_proxy_version" {
       type        = string
    -  default     = "v1.28.8-eksbuild.5"
    +  default     = "v1.28.12-eksbuild.5"
       description = "You should grab the appropriate version number from: https://docs.aws.amazon.com/eks/latest/userguide/managing-kube-proxy.html"
     }
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Ensuring consistency of version numbers across different files in the module is important for maintainability and reduces the risk of configuration mismatches. This suggestion addresses potential inconsistencies and aligns the versions, which is beneficial for the module's reliability.

    7
    Enhancement
    Update the kube-proxy version to the latest compatible with EKS 1.28

    Consider updating the kube_proxy_version to match the latest version compatible with
    EKS 1.28. The current version might be outdated.

    tests/main.tf [7]

    -kube_proxy_version = "v1.28.12-eksbuild.5"
    +kube_proxy_version = "v1.28.13-eksbuild.1"
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: The suggestion to update the kube-proxy version to a newer compatible version can help ensure compatibility and potentially address any known issues with the current version. However, it is not clear if the suggested version is indeed the latest compatible version, so the impact is moderate.

    5

    💡 Need additional feedback ? start a PR chat

    @venkatamutyala venkatamutyala merged commit fd95612 into main Oct 23, 2024
    6 checks passed
    @venkatamutyala venkatamutyala deleted the feat/update-eks-ami branch October 23, 2024 15:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request include-in-release-notes minor Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants