Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update calico #192

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Feat/update calico #192

merged 2 commits into from
Dec 2, 2024

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Dec 2, 2024

PR Type

enhancement, configuration changes


Description

  • Updated the Calico Helm chart version in the run.sh script from v3.27.4 to v3.28.2 to ensure the latest features and fixes are included.
  • Modified the calico.yaml configuration file to update the tigera/operator image version from v1.32.10 to v1.34.5.
  • Updated the calicoctl tag in calico.yaml from v3.27.4 to v3.28.2 for consistency with the Helm chart.

Changes walkthrough 📝

Relevant files
Enhancement
run.sh
Update Calico Helm chart version in script                             

tests/run.sh

  • Updated Calico Helm chart version from v3.27.4 to v3.28.2.
+1/-1     
Configuration changes
calico.yaml
Update Calico configuration versions                                         

tests/calico.yaml

  • Updated tigera/operator image version from v1.32.10 to v1.34.5.
  • Updated calicoctl tag from v3.27.4 to v3.28.2.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Compatibility
    Verify that the new Calico operator version v1.34.5 is compatible with the cluster's Kubernetes version and other components

    Configuration Validation
    Ensure that any new configuration options or deprecated settings between Calico versions v3.27.4 and v3.28.2 have been properly addressed

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Add verification of successful component deployment before proceeding with subsequent operations

    Add a verification step after installing Calico to ensure the installation was
    successful and all pods are running before proceeding with node pool deployment.

    tests/run.sh [26-30]

     helm install calico projectcalico/tigera-operator --version v3.28.2 --namespace tigera-operator -f calico.yaml --create-namespace
    +echo "Waiting for Calico pods to be ready..."
    +kubectl wait --for=condition=ready pods --all -n calico-system --timeout=300s
     echo "::endgroup::"
     
     echo "::group::Deploying new Node Pool"
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Adding a pod readiness check is crucial for ensuring Calico CNI is fully operational before proceeding with node pool deployment. Without this verification, subsequent operations might fail if Calico isn't properly initialized.

    9

    💡 Need additional feedback ? start a PR chat

    Copy link

    sonarqubecloud bot commented Dec 2, 2024

    @venkatamutyala venkatamutyala merged commit 789b0f2 into main Dec 2, 2024
    6 of 7 checks passed
    @venkatamutyala venkatamutyala deleted the feat/update-calico branch December 2, 2024 23:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants