refactor: ♻️ Changed disabled_mods setting to load metadata
#394
Conversation
KANAjetzt
added
enhancement
| ## Mods in this array will only load metadata but will not apply any modifications. | ||
| ## This can be used to deactivate example mods. | ||
| ## Mods in this array are overridden by the settings in the user profile. | ||
| @export var deactivated_mods: Array[String] = [] |
There was a problem hiding this comment.
why are we changing it to deactivated? seems like a pointless breaking change?
There was a problem hiding this comment.
I thought about adding a "disabled" and "deactivated" setting first, one to keep the current behavior and one for this change.
I'm not sure what is more accurate.
I don't worry too much about breaking changes for 4.x-v7.
There was a problem hiding this comment.
deactivated makes more sense to me, so i think the rename is fine. but yes, this is breaking and no we can't overlook that anymore since we have windowkill now which relies on it. so we need a proper deprecation both for that and for mod_configs
There was a problem hiding this comment.
unless it's not directly used, then we are fine
KANAjetzt
force-pushed
the
feat_deactivate_mods_setting
branch
from
1ab1f4a
to
48d501c
Compare
- Renamed `disabled_mods` to `deactivated_mods`. - Moved default profile creation in `mod_loader.gd` from `_ready()` to `_load_mods()`. This is required so mod configs can be loaded on the first run of the game. - Separated loading of mod manifests and mod configs to allow the creation of the default user profile in between. - Demoted "No profile" error from error to info because on the first run of the game, the file will not be there. - Fixed the `LOG_NAME` of `_ModLoaderPath`. - Changed the `MOD_CONFIG_DIR_PATH` from `"user://configs"` to `"user://mod_configs"` to make it clearer what kind of configs are stored. - Fixed an issue where `current_config` is `null` because it didn't get set in `ModData._load_config`.
KANAjetzt
force-pushed
the
feat_deactivate_mods_setting
branch
from
48d501c
to
cea915e
Compare
|
I have moved the changes into separate issues so we can tackle them once we have completed the major changes for v7. |
disabled_modstodeactivated_mods.mod_loader.gdfrom_ready()to_load_mods(). This is required so mod configs can be loaded on the first run of the game.LOG_NAMEof_ModLoaderPath.MOD_CONFIG_DIR_PATHfrom"user://configs"to"user://mod_configs"to make it clearer what kind of configs are stored.current_configwasnullbecause it wasn't set inModData._load_config.