-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved glob pattern matching. #37
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
return err | ||
} | ||
case '!': | ||
if err := c.compileSubExpression("(?~", ")", "\\!"); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Negative matches are not actually supported. Go regexp supports neither negative lookahead (?!)
, nor the Ruby's absence operator (?~)
that we'd need to implement this. This returns an ErrInvalidPerlOp
.
@@ -33,7 +33,7 @@ type FirebaseManifest struct { | |||
|
|||
func (mf FirebaseManifest) processRedirects(w http.ResponseWriter, r *http.Request) (bool, error) { | |||
for _, redirect := range mf.Redirects { | |||
pattern, err := CompileExtGlob(redirect.Source) | |||
pattern, err := CompileExtGlob("/" + strings.TrimPrefix(redirect.Source, "/")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be compatible with Firebase, patterns should start with a /
, and be matched against r.URL.Path
(which also starts with a /
).
10/10 for the test suite! That gives me a lot of confidence. Well done. |
As discussed in #36.