Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate flags for enabling/disabling each preview feature in isolation. #196

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Create separate flags for enabling/disabling each preview feature in isolation. #196

wants to merge 14 commits into from
+121 −78

Conversation

saranyaloganathan23
Copy link
Collaborator

No description provided.

ojarjur
ojarjur requested changes Dec 3, 2024
View reviewed changes
dataproc_jupyter_plugin/commons/vertexPlatform.py Outdated Show resolved Hide resolved
dataproc_jupyter_plugin/controllers/vertexPlatform.py Outdated Show resolved Hide resolved
dataproc_jupyter_plugin/handlers.py Outdated Show resolved Hide resolved
ojarjur
ojarjur reviewed Dec 11, 2024
View reviewed changes
src/utils/const.ts Outdated Show resolved Hide resolved
ojarjur
ojarjur reviewed Dec 11, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
ojarjur
ojarjur reviewed Dec 14, 2024
View reviewed changes
src/index.ts Show resolved Hide resolved
ojarjur
ojarjur reviewed Dec 14, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
ojarjur
ojarjur reviewed Dec 14, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@ojarjur ojarjur changed the title disabling GCS in vertex platform Create separate flags for enabling/disabling each preview feature in isolation. Jan 8, 2025
VictorShiAmazingGrace
VictorShiAmazingGrace requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@VictorShiAmazingGrace VictorShiAmazingGrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add some meaningful PR descriptions to make it easier for reviewers to get the full context of this change? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha-accenture harsha-accenture Awaiting requested review from harsha-accenture

@ywskycn ywskycn Awaiting requested review from ywskycn

@jinnthehuman jinnthehuman Awaiting requested review from jinnthehuman

@VictorShiAmazingGrace VictorShiAmazingGrace Awaiting requested review from VictorShiAmazingGrace

@ojarjur ojarjur Awaiting requested review from ojarjur

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saranyaloganathan23 @ojarjur @VictorShiAmazingGrace @kokoro-team