-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Geekbench 6 Benchmark #5353
base: master
Are you sure you want to change the base?
Conversation
…hmarker into addgeekbench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some small nits and questions.
Hi leyli16, it has came to my attention that we already have a geekbench6 linux implementation, you cannot see it because it is not externalized here on github. |
Thank you for the clarification. I’ve already addressed the Windows implementation, and I’d be happy to collaborate further to ensure there’s no conflict. Let me know how I can assist! |
This PR addresses the requirements outlined in [Issue #5238]. The following changes have been implemented:
Summary of Changes:
geekbench_benchmark.py
files in bothlinux_benchmarks
andwindows_benchmarks
directories.GetConfig
,Prepare
,Run
, andCleanup
functions, each containing initial structure with pass/return statements, making the benchmark operational within PKB.geekbench.py
package withinlinux_packages
andwindows_packages
for installing Geekbench.Manually ran Geekbench6 locally, producing output used for parsing and testing.
Stored Geekbench output in
data/geekbench
as a raw data file for testing the parsing function.Developed
ParseResults
function ingeekbench.py
to process Geekbench output. The function produces a list of PKB Samples, with each sample representing a unique metric with:=
metric_name, metric_value, metric_unit, and metric_metadata
.Added unit tests to verify accurate parsing and structured output for each metric from both CPU and GPU tests.
Update from 11/29:
Prepare()
to install Geekbench (vm.install('geekbench')
).Run()
to trigger Geekbench execution.ParseResults
while continuing execution.ParseResults()
to usesample.Sample
for consistent output.geekbench_benchmark
for naming consistency.