Skip to content

Commit

Permalink
chore: use sync instead of async in test (#396)
Browse files Browse the repository at this point in the history
`test_Connector_remove_cached_bad_instance` doesn't need to be async,
because it can use the event loop that is generated by
`Connector.__init__()` function.
  • Loading branch information
rhatgadkar-goog authored Nov 18, 2024
1 parent e8fbbdf commit 5255fbb
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions tests/unit/test_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def test_Connector_close_called_multiple_times(credentials: FakeCredentials) ->
connector.close()


async def test_Connector_remove_cached_bad_instance(
def test_Connector_remove_cached_bad_instance(
credentials: FakeCredentials,
) -> None:
"""When a Connector attempts to retrieve connection info for a
Expand All @@ -219,14 +219,8 @@ async def test_Connector_remove_cached_bad_instance(
"""
instance_uri = "projects/test-project/locations/test-region/clusters/test-cluster/instances/bad-test-instance"
with Connector(credentials) as connector:
connector._keys = asyncio.wrap_future(
asyncio.run_coroutine_threadsafe(
generate_keys(), asyncio.get_running_loop()
),
loop=asyncio.get_running_loop(),
)
with pytest.raises(ClientResponseError):
await connector.connect_async(instance_uri, "pg8000")
connector.connect(instance_uri, "pg8000")
assert instance_uri not in connector._cache


Expand Down

0 comments on commit 5255fbb

Please sign in to comment.