Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed connection calls should stop the background refresh #265

Closed
jackwotherspoon opened this issue Mar 6, 2024 · 1 comment · Fixed by #389
Closed

Failed connection calls should stop the background refresh #265

jackwotherspoon opened this issue Mar 6, 2024 · 1 comment · Fixed by #389
Assignees
@rhatgadkar-goog
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

When an Admin API call fails for an instance, the connector should stop the background refresh in case the failure was caused by a unrecoverable error (instance was deleted, connection string is completely wrong, etc).
@jackwotherspoon jackwotherspoon added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 6, 2024
@jackwotherspoon jackwotherspoon self-assigned this Mar 6, 2024
@jackwotherspoon
Copy link
Collaborator Author

Cloud SQL ref: GoogleCloudPlatform/cloud-sql-python-connector#1118

@enocom enocom assigned enocom and unassigned jackwotherspoon Sep 6, 2024
@enocom enocom assigned rhatgadkar-goog and unassigned enocom Oct 9, 2024
@rhatgadkar-goog rhatgadkar-goog linked a pull request Nov 12, 2024 that will close this issue
feat: invalidate cache on bad connection info and failed IP lookup #389
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhatgadkar-goog rhatgadkar-goog

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@enocom @jackwotherspoon @rhatgadkar-goog