feat: invalidate cache on bad connection info and failed IP lookup #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatgadkar-goog
changed the title
jackwotherspoon
requested changes
Nov 14, 2024
enocom
reviewed
Nov 14, 2024
rhatgadkar-goog
changed the title
enocom
approved these changes
Nov 15, 2024
jackwotherspoon
approved these changes
Nov 15, 2024
rhatgadkar-goog
deleted the
265-failed-connection-calls-should-stop-the-background-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is analogous to CloudSQL's GoogleCloudPlatform/cloud-sql-python-connector#1118.
The
Connectorcaches connection info for future connections and schedules refresh operations. For unrecoverable errors, the cache should be invalidated to stop future bad refreshes. The cache should also be invalidated on failed IP lookups. This PR does these things.