Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh token prior to metadata exchange #351

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: refresh token prior to metadata exchange #351

merged 1 commit into from
Jul 22, 2024

Conversation

enocom
Copy link
Member

@enocom enocom commented Jul 22, 2024

In heavy usage, there can be cases where the client does not refresh the token but then the token expires prior to the metadata exchange. This commit ensures that the token is always fresh before proceeding to the metadata exchange.

Fixes #346

Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you'll want to do nox -s format to fix the lint issue

In heavy usage, there can be cases where the client does not refresh the
token but then the token expires prior to the metadata exchange. This
commit ensures that the token is always fresh before proceeding to the
metadata exchange.

Fixes #346
@enocom enocom merged commit 1ab11e6 into main Jul 22, 2024
15 checks passed
@enocom enocom deleted the fresh-token branch July 22, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid token in metadata exchange
3 participants