Fix make cloud_function build step hashing deterministic #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctx.imports is an unsorted dictionary, causing unnecessary updates when the order arbitrarily changes.
The zipfile contains extra attributes like the timestamp that are included in the return value of getvalue(), causing a different md5 hash every second.
elwinarens
changed the title
elwinarens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.imports is an unsorted dictionary, causing unnecessary updates of the cloud function resource when the order arbitrarily changes.
Additionally, the return value of
StringIO.getvalue()contains timestamp information that causes the md5 hexdigest to change every second.