Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF: plan -refresh=false for google_compute_ha_vpn_gateway with gcs backend has resource replacement #12422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akshat-jindal-nit
Copy link
Contributor

@akshat-jindal-nit akshat-jindal-nit commented Nov 25, 2024

Bug: b/376368181
Issue: hashicorp/terraform-provider-google#19978
This particular change is the main culprit of this issue https://screenshot.googleplex.com/79xwUXBEcc5SYAg.
Looks like this issue start occurring from the release v5.40.0 https://screenshot.googleplex.com/367U6wou3dHnzaJ.

Release Note Template for Downstream PRs (will be copied)

bug: Fixed a bug (b/376368181) where `terraform plan -refresh=false` with `google_compute_ha_vpn_gateway` and a GCS backend would incorrectly show a resource replacement. 

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 25, 2024
@harshithpatte-g
Copy link
Contributor

@akshat-jindal-nit can repro this issue with a test? Could we add that test?

@akshat-jindal-nit
Copy link
Contributor Author

@akshat-jindal-nit can repro this issue with a test? Could we add that test?

@harshithpatte-g this particular change is related to terraform plan -refresh=false related changes. I think we don't write any particulars tests for it.
But this TestAccDataSourceComputeHaVpnGateway is running successfully as our changes are intended to impact the default_values only .

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants