Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an initial set of uniform DCGM GPU metrics in dcgmreceiver. #219

Merged
merged 39 commits into from
Sep 13, 2024
Merged

Implement an initial set of uniform DCGM GPU metrics in dcgmreceiver. #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
8bac1d2
Better assertions in tests.
igorpeshansky Jun 17, 2024
00976dd
Remove support for K80 (EOL).
igorpeshansky Jun 19, 2024
afd9512
Fix supported field filtering to only consider profiling fields.
igorpeshansky Jun 20, 2024
e78b829
Enabled option reorder.
igorpeshansky Jun 21, 2024
c33595c
Turn the GPU device metric attributes into resource attributes.
igorpeshansky May 24, 2024
89c3919
Get rid of dcgmNameToMetricName and use DCGM field names directly.
igorpeshansky May 29, 2024
70d1caf
More precise value errors.
igorpeshansky Jun 20, 2024
6c3748c
Add most metrics from the doc.
igorpeshansky May 29, 2024
3560661
Turn gpu.dcgm.sm.occupancy off by default.
igorpeshansky Jun 21, 2024
24a21cb
Ingest new metrics instead.
igorpeshansky May 30, 2024
5c28868
Add test data for H100.
igorpeshansky Jun 19, 2024
80430df
Remove old metrics.
igorpeshansky May 30, 2024
ef78211
Check for supported non-profiling fields by validating polled values.
igorpeshansky Jun 20, 2024
c7e015f
Pull in deltatorate processor.
igorpeshansky Jun 13, 2024
af0f4d9
Update attribute names; rename {pcie|nvlink}.traffic to {pcie|nvlink}…
igorpeshansky Jun 24, 2024
20f3b8d
Implement fallbacks.
igorpeshansky Jun 25, 2024
2ab8868
Skip test gracefully when pausing profiling not supported.
igorpeshansky Jun 27, 2024
4cc8a8b
Don't fail client tests on blank values.
igorpeshansky Jun 28, 2024
d0ad1ad
Fix supported field error handling.
igorpeshansky Jul 17, 2024
d19b09e
Fix lint errors.
igorpeshansky Jul 18, 2024
59d2a4a
Fix description of the network.io.direction label.
igorpeshansky Jul 23, 2024
97d2689
Avoid panics when tests run with no GPU.
igorpeshansky Jul 25, 2024
d47313e
Review feedback.
igorpeshansky Jul 25, 2024
2ad3400
Need to aggregate per device.
igorpeshansky Jul 28, 2024
e9f3300
Make gpu.dcgm.pcie.io and gpu.dcgm.nvlink.io cumulative.
igorpeshansky Jul 25, 2024
adb4c2e
Pull in cumulativetodelta processor.
igorpeshansky Jul 26, 2024
85bd141
Decouple the client from the receiver config.
igorpeshansky Jul 26, 2024
b82fa9b
Store the typed value directly in dcgmMetric; avoid unsafe.
igorpeshansky Jul 26, 2024
ccfd16e
Oops, temperature and clock frequency and energy consumption are int64.
igorpeshansky Jul 26, 2024
e7ffb3e
Scale energy consumption properly.
igorpeshansky Jul 26, 2024
e4a0026
More debug logging.
igorpeshansky Jul 26, 2024
e673697
Implement a rateIntegrator struct.
igorpeshansky Jul 26, 2024
b779893
Implement a cumulativeTracker struct.
igorpeshansky Jul 27, 2024
d8362b3
Really pull in the cumulativetodelta processor.
igorpeshansky Aug 14, 2024
dd39c32
Collect metrics asynchronously (#223)
quentinmit Sep 11, 2024
5de8b1c
Fix lint errors.
igorpeshansky Sep 11, 2024
ea0eba5
Fix data race in scraper_test.
igorpeshansky Sep 12, 2024
ac52c0f
Cleanups.
igorpeshansky Sep 13, 2024
5c0f8c4
Merge branch 'master' into igorpeshansky-dcgm-new-metrics
igorpeshansky Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ linters-settings:
- (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
disable:
- fieldalignment
- shadow
enable-all: true
misspell:
locale: US
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlemanagedprometheusexporter v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.102.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor v0.102.0
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,10 @@ github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometh
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometheusremotewrite v0.102.0/go.mod h1:+Vlutd4t2XluxHYbIAfZiz3z5uWbsbiIUpipV5AnLtk=
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.102.0 h1:adfJy3Sev2MaD6+plcmsSecpzy8h4MJT7eXEuif/2Ew=
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.102.0/go.mod h1:FJmA939yem9GSEbqjCK6CXVbPfNPFKhvKnn+nWNpWio=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor v0.102.0 h1:q4VV17TxeMm0FOeyFXAO4gSRf2ZLtKTh0/l5goxhRsY=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor v0.102.0/go.mod h1:FlP/8TVT768TAh5kpvVX3AQ5/UXJWBuSSCFhO3fE+E0=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor v0.102.0 h1:mj3t9/FAQZjcZJA2kjgbpz2fSK9yD/pYpmqKEWpHJ1A=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor v0.102.0/go.mod h1:IIIjEblgrNISbDY7GPMMto9kEVIf0n9IeJoVru89kfY=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.102.0 h1:DaEYlVCn58GtkyYVK0IT/ZMjRFJ+BfmR0p9I0Eq42aQ=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.102.0/go.mod h1:u9x08rUCWdgI8Nle5XOMTCmxd0K26KTZvMMA5H8Xjyg=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.102.0 h1:huh7V8uqMakQGdnbOqTSZihfoDeOIbNHfFt62HMsk5k=
Expand Down
360 changes: 194 additions & 166 deletions receiver/dcgmreceiver/client.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading