Rename GCPResource -> GCPResourceDetector #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable. What is the motivation for the change? |
psx95
changed the title
While working on #267, I noticed this name was confusing when manually using resource detectors (most of our samples were using it via auto-configuration so it went un-noticed before). |
|
Given #266 might move this anyways, lets stick with the current naming for now to avoid breaking users unnecessarily. |
|
we can talk about it at triage today |
|
This could be done as part of #266, we can avoid this breaking change in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains only refactoring required to accommodate the name change.
This is a breaking change for code depending on
detector-resources.This change was tested manually as well via the use of auto-exporter.