Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASING.md #375

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update RELEASING.md #375

merged 1 commit into from
Sep 23, 2024

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Sep 23, 2024

Description

Updates release instructions based on the slight changes noticed in release behavior based on the new plugin version.

Highlights

  • The release task no longer fails if tags cannot be pushed upstream (due to permissions issue stemming from absence of credentials manager on the machine from which the release is being made)
  • The release task takes longer time to completion since it probably retries pushing tags. The current release v0.32.0 took roughly 20 minutes to complete.

fixes #363

@psx95 psx95 requested a review from aabmass September 23, 2024 18:52
@psx95 psx95 marked this pull request as ready for review September 23, 2024 18:52
@psx95 psx95 requested a review from a team as a code owner September 23, 2024 18:52
@@ -106,9 +106,10 @@ $ ./gradlew candidate -Prelease.version=0.14.0
$ git push origin v0.14.0
```

*Note: if you do not have a CredentialsProvider registered for GitHub, the `candidate` task may fail to upload tags to the GitHub repository and the overall command will report a failure. In this case, before retrying the command - check if the staging repository is created on the [nexus repository manager](https://oss.sonatype.org/#stagingRepositories). If the repository is already created, manually push the tag on GitHub, and continue with the next steps.*
*Note: If you do not have a CredentialsProvider registered for GitHub, the `candidate` task may fail to upload tags to the GitHub repository and the overall command may take a long time to report completion on the task. In this case, before moving forward - check if tags were pushed to GitHub. If not, manually push the tags before continuing.*\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the trailing \ on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is to provide a break in the paragraph.
A new line character was leaving an entire blank line so the passage looked disconnected.

@psx95 psx95 merged commit 371d1cd into main Sep 23, 2024
18 checks passed
@psx95 psx95 deleted the psx95-patch-1 branch September 23, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to cut a release and see if nebula release plugin is still working after upgrade
2 participants