Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AI Experimentation Solution #490

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

cartyc
Copy link
Contributor

@cartyc cartyc commented Aug 22, 2023

This package includes a project that is pre-configured with the required services to begin using vertex ai for experimentation with Google AI services.

Some services are not fully available in Canada and this project adds an organization policy exemption for the target project to facilitate the deployment. This package is not intended for use beyond profile 1 and the experimentation Landing Zone.

A future package will be added to demonstrate the creation of vertex ai components using KRM.

@cartyc cartyc requested a review from fmichaelobrien as a code owner August 22, 2023 12:51
@cartyc
Copy link
Contributor Author

cartyc commented Aug 22, 2023

Got a little messy with a rebase, will squash.

fmichaelobrien
fmichaelobrien previously approved these changes Aug 22, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

fmichaelobrien
fmichaelobrien previously approved these changes Aug 22, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@davelanglois-ssc davelanglois-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very interesting use case

solutions/vertexai/ai-experimentation/setters.yaml Outdated Show resolved Hide resolved
@cartyc
Copy link
Contributor Author

cartyc commented Aug 28, 2023

@davelanglois-ssc we've been seeing an influx of requests for GenAI sandboxes and the intent of this is to help expedite teams time to getting a PoC off the ground. Hopefully we can also leverage some of the VertexAI Alphav1 CRDs as well

fmichaelobrien
fmichaelobrien previously approved these changes Aug 28, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - post comments/edits

fmichaelobrien
fmichaelobrien previously approved these changes Aug 31, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
the autopilot readme code - I will test this later

fmichaelobrien
fmichaelobrien previously approved these changes Aug 31, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
if you are still testing changes - I'll review them in batch later

@cartyc
Copy link
Contributor Author

cartyc commented Aug 31, 2023

@fmichaelobrien ya I probably should put it as draft. I originally tested it with the experimenation landing zone and now running it with the just the client-landing-zone and started getting some errors. Hoping to allow it to work with both so users have some flexibility with deployment.

@cartyc
Copy link
Contributor Author

cartyc commented Aug 31, 2023

Redeployed and working a-ok. Safe for a review :)

Hierarchy View
image

Enabled APIs
image

KCC Resource List Healthy

 k get gcp
NAME                                                                                        AGE    READY   STATUS     STATUS AGE
iampolicymember.iam.cnrm.cloud.google.com/docai-carty-vertex-altostrat-permissions          149m   True    UpToDate   148m
iampolicymember.iam.cnrm.cloud.google.com/docwarehouse-carty-vertex-altostrat-permissions   149m   True    UpToDate   148m
iampolicymember.iam.cnrm.cloud.google.com/vertexai-carty-vertex-altostrat-permissions       149m   True    UpToDate   148m

NAME                                                                         AGE    READY   STATUS     STATUS AGE
project.resourcemanager.cnrm.cloud.google.com/carty-vertex-altostrat         149m   True    UpToDate   148m
project.resourcemanager.cnrm.cloud.google.com/com-test-net-host-project-12   13d    True    UpToDate   13d

NAME                                                                                       AGE    READY   STATUS     STATUS AGE
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-bigquery                 148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-billing                  148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-cloud-storage            148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-contentwarehouse         149m   True    UpToDate   148m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-discover-engine          148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-documentai               148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-iam                      148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-nlp                      148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-resourcemanager          148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-serviceusage             148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/carty-vertex-altostrat-vertexai                 148m   True    UpToDate   147m
service.serviceusage.cnrm.cloud.google.com/com-test-net-host-project-12-compute            13d    True    UpToDate   13d
service.serviceusage.cnrm.cloud.google.com/com-test-net-host-project-12-container          13d    True    UpToDate   13d
service.serviceusage.cnrm.cloud.google.com/com-test-net-host-project-12-dns                13d    True    UpToDate   13d
service.serviceusage.cnrm.cloud.google.com/com-test-net-host-project-12-servicedirectory   13d    True    UpToDate   13d

Copy link
Collaborator

@davelanglois-ssc davelanglois-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor updates to some comments,, other than that, it is a great addition !! good job chris

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartyc cartyc merged commit ad0bdcc into GoogleCloudPlatform:main Sep 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants