Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable missing logging for fw rules #524

Merged
merged 1 commit into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ spec:
targetServiceAccounts:
- name: workload-name-sa # kpt-set: ${workload-name}-sa
namespace: project-id-tier4 # kpt-set: ${project-id}-tier4
logConfig:
metadata: "INCLUDE_ALL_METADATA"
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
description: "allow access to example.com"
direction: "EGRESS"
disabled: false
enableLogging: false
enableLogging: true
firewallPolicyRef:
name: client-name-standard-applications-infrastructure-fwpol # kpt-set: ${client-name}-standard-applications-infrastructure-fwpol
namespace: client-name-networking # kpt-set: ${client-name}-networking
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ spec:
targetServiceAccounts:
- name: workload-name-sa # kpt-set: ${workload-name}-sa
namespace: project-id-tier4 # kpt-set: ${project-id}-tier4
logConfig:
metadata: "INCLUDE_ALL_METADATA"
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ spec:
description: "Exclude communication with private IP ranges, leaving only Internet traffic to be inspected (EGRESS)"
direction: "EGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-client-folder-fwpol # kpt-set: ${client-name}-client-folder-fwpol
Expand All @@ -53,6 +54,7 @@ spec:
description: "Exclude communication with private IP ranges, leaving only Internet traffic to be inspected (INGRESS)"
direction: "INGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-client-folder-fwpol # kpt-set: ${client-name}-client-folder-fwpol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ spec:
description: "Goto next for IAP"
direction: "INGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-client-folder-fwpol # kpt-set: ${client-name}-client-folder-fwpol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ spec:
description: "Goto next for LB health checks"
direction: "INGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-client-folder-fwpol # kpt-set: ${client-name}-client-folder-fwpol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ spec:
description: "Exclude communication with private IP ranges, leaving only Internet traffic to be inspected (EGRESS)"
direction: "EGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-standard-applications-infrastructure-fwpol # kpt-set: ${client-name}-standard-applications-infrastructure-fwpol
Expand All @@ -53,6 +54,7 @@ spec:
description: "Exclude communication with private IP ranges, leaving only Internet traffic to be inspected (INGRESS)"
direction: "INGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-standard-applications-infrastructure-fwpol # kpt-set: ${client-name}-standard-applications-infrastructure-fwpol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ spec:
description: "Goto next for IAP"
direction: "INGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-standard-applications-infrastructure-fwpol # kpt-set: ${client-name}-standard-applications-infrastructure-fwpol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ spec:
description: "Goto next for LB health checks"
direction: "INGRESS"
disabled: false
# logging not supported for goto_next rules
enableLogging: false
firewallPolicyRef:
name: client-name-standard-applications-infrastructure-fwpol # kpt-set: ${client-name}-standard-applications-infrastructure-fwpol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ spec:
- "192.168.0.0/16"
networkRef:
name: host-project-id-global-standard-vpc # kpt-set: ${host-project-id}-global-standard-vpc
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
# Default egress deny all
# AC-4, AC-4(21), SC-7(C), SC-7(5)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,5 @@ spec:
- 10.255.255.254/32
networkRef:
name: host-project-id-global-standard-vpc # kpt-set: ${host-project-id}-global-standard-vpc
logConfig:
metadata: "INCLUDE_ALL_METADATA"
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ spec:
targetServiceAccounts:
- name: project-id--instance-name-sa # kpt-set: ${project-id}--${instance-name}-sa
namespace: client-name-admin # kpt-set: ${client-name}-admin
logConfig:
metadata: "INCLUDE_ALL_METADATA"
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,5 @@ spec:
- "130.211.0.0/22"
destinationRanges: # kpt-set: ${podIpv4Range}
- podIpv4Range
logConfig:
metadata: "INCLUDE_ALL_METADATA"
10 changes: 10 additions & 0 deletions solutions/project/hub-env/fortigate/firewall.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ spec:
name: hub-global-external-vpc
sourceRanges:
- 0.0.0.0/0
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
## External Load Balancers health checks
## https://cloud.google.com/load-balancing/docs/health-checks#fw-rule
Expand All @@ -56,6 +58,8 @@ spec:
- "130.211.0.0/22"
targetServiceAccounts:
- name: hub-fortigatesdn-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
## Internal allow spokes to fortigates
## AC-3(7) use of SA account with limited permissions
Expand All @@ -79,6 +83,8 @@ spec:
- 10.0.0.0/8
targetServiceAccounts:
- name: hub-fortigatesdn-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
## Internal Load Balancers health checks
## https://cloud.google.com/load-balancing/docs/health-checks#fw-rule
Expand All @@ -104,6 +110,8 @@ spec:
- "130.211.0.0/22"
targetServiceAccounts:
- name: hub-fortigatesdn-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
## Enable traffic on mgmt network for fortigates HA
## AC-3(7) use of SA account with limited permissions
Expand All @@ -126,3 +134,5 @@ spec:
- name: hub-fortigatesdn-sa
targetServiceAccounts:
- name: hub-fortigatesdn-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ spec:
- "35.235.240.0/20"
targetServiceAccounts:
- name: hub-managementvm-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
## Management VM to Fortigates - ICMP and TCP SSH, HTTPS
## AC-17(1) - Users are forced to use IAP Desktop to access (via RDP) the management Google Compute Engine in order to access and manage the Fortigate appliance through SSH or HTTPS.
Expand Down Expand Up @@ -65,3 +67,5 @@ spec:
- name: hub-managementvm-sa
targetServiceAccounts:
- name: hub-fortigatesdn-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,6 @@
- "10.1.1.2/32"
targetServiceAccounts:
- name: project-id-service1-sa # kpt-set: ${project-id}-service1-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
```
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,6 @@
- "0.0.0.0/0"
targetServiceAccounts:
- name: project-id-workload1-sa # kpt-set: ${project-id}-workload1-sa
logConfig:
metadata: "INCLUDE_ALL_METADATA"
```
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ spec:
- 10.255.255.254/32
networkRef:
name: project-id-global-vpc1-vpc # kpt-set: ${project-id}-global-vpc1-vpc
logConfig:
metadata: "INCLUDE_ALL_METADATA"
---
# Default egress deny all
# AC-4, AC-4(21), SC-7(C), SC-7(5)
Expand Down Expand Up @@ -60,3 +62,5 @@ spec:
- 10.2.3.0/24
networkRef:
name: project-id-global-vpc1-vpc # kpt-set: ${project-id}-global-vpc1-vpc
logConfig:
metadata: "INCLUDE_ALL_METADATA"