Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip-docs: Add Guardrails Documentation #533

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cartyc
Copy link
Contributor

@cartyc cartyc commented Sep 27, 2023

Request from Client to include detailed Documentation on how guardrails are implemented with the Landing Zone solution.

The goal of this PR is to add clear documentation to address this gap.

@cartyc cartyc marked this pull request as draft September 27, 2023 12:52
fmichaelobrien
fmichaelobrien previously approved these changes Sep 27, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Will re-approve when out of draft


### Segment and separate information based on sensitivity of information

The creation of network infrastructure will be handled through the [accelerator templates](https://github.com/canada-ca/accelerators_accelerateurs-gcp).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tf code reference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on removing all of those :) Do call out any inconsistencies or areas we should update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike!

fmichaelobrien
fmichaelobrien previously approved these changes Sep 27, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM commit 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants