Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding security control tags #810

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: adding security control tags #810

merged 3 commits into from
Feb 13, 2024

Conversation

davelanglois-ssc
Copy link
Collaborator

@davelanglois-ssc davelanglois-ssc commented Feb 2, 2024 •
edited
Loading

Adding security control tags to the following packages:

  • client-landing-zone
  • core-landing-zone
  • gke/configconnector/gke-admin-proxy
  • gke/configconnector/gke-cluster-autopilot
  • gke/configconnector/gke-defaults
  • gke/kubernetes/cluster-defaults
  • ids

closes #804

alaincormier-ssc
alaincormier-ssc previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@alaincormier-ssc alaincormier-ssc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

reminder: if we want to bump the release tags, to add "fix:" in the PR/commit title before merging

fmichaelobrien
fmichaelobrien previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Dave, also reviewing the Python change

tackaberry
tackaberry previously approved these changes Feb 2, 2024
View reviewed changes
@tackaberry
Copy link
Collaborator

Awesome @davelanglois-ssc . Looks good.

@davelanglois-ssc
Copy link
Collaborator Author

don't merge yet, additionnal tags need to be added

@davelanglois-ssc
Copy link
Collaborator Author

don't merge yet, additionnal tags need to be added

It's now READY. all tags have been added

fmichaelobrien
fmichaelobrien approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC, SI, SC changes look good
/lgtm

@alaincormier-ssc alaincormier-ssc changed the title adding security control tags fix: adding security control tags Feb 9, 2024
@davelanglois-ssc davelanglois-ssc merged commit cb877a4 into main Feb 13, 2024
3 checks passed
@davelanglois-ssc davelanglois-ssc deleted the gh804-adding-security-control-tags branch February 13, 2024 13:00
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaincormier-ssc alaincormier-ssc alaincormier-ssc approved these changes

@fmichaelobrien fmichaelobrien fmichaelobrien approved these changes

@lucstjean-ssc lucstjean-ssc Awaiting requested review from lucstjean-ssc

@Michael-McAuley-SSC Michael-McAuley-SSC Awaiting requested review from Michael-McAuley-SSC

@CraigBaltzer CraigBaltzer Awaiting requested review from CraigBaltzer

@stephanemillaire-ssc stephanemillaire-ssc Awaiting requested review from stephanemillaire-ssc

@danielsvensson-ssc danielsvensson-ssc Awaiting requested review from danielsvensson-ssc

@seanwilkens-ssc seanwilkens-ssc Awaiting requested review from seanwilkens-ssc

@anoopsidhu-ssc anoopsidhu-ssc Awaiting requested review from anoopsidhu-ssc

@borkodjurkovic-ssc borkodjurkovic-ssc Awaiting requested review from borkodjurkovic-ssc

@johnswayty-ssc johnswayty-ssc Awaiting requested review from johnswayty-ssc

@tackaberry tackaberry Awaiting requested review from tackaberry tackaberry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: security controls tagging
4 participants
@davelanglois-ssc @tackaberry @fmichaelobrien @alaincormier-ssc