Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding new setters for client folder display name #888

Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat: adding new setters for client folder display name #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion solutions/client-setup/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ Package to setup a client's namespaces, folder, management project and root sync
| Name | Value | Type | Count |
|------------------------------|---------------------------------|------|-------|
| client-billing-id | AAAAAA-BBBBBB-CCCCCC | str | 1 |
| client-folder-display-name | client-folder-display-name | str | 1 |
| client-management-project-id | client-management-project-12345 | str | 111 |
| client-name | client1 | str | 149 |
| client-name | client1 | str | 148 |
| dns-project-id | dns-project-12345 | str | 1 |
| management-namespace | config-control | str | 27 |
| management-project-id | management-project-12345 | str | 6 |
Expand Down
2 changes: 1 addition & 1 deletion solutions/client-setup/folder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ metadata:
name: clients.client-name # kpt-set: clients.${client-name}
namespace: hierarchy
spec:
displayName: client-name # kpt-set: ${client-name}
displayName: client-folder-display-name # kpt-set: ${client-folder-display-name}
folderRef:
name: clients
3 changes: 3 additions & 0 deletions solutions/client-setup/setters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ data:
# Name for the client, lowercase only.
# customization: required
client-name: 'client1'
# Client folder display name
# customization: required
client-folder-display-name: client-folder-display-name
#
# Client's Billing Account ID to associate with the client's management project. The projects-sa will need billing user role permission granted.
# alternatively, because the client management project contains very limited resources, it could be set to the core-landing-zone billing id (the projects-sa should already have permissions set during initial post deployment configurations)
Expand Down