Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distinct VPC host prep core-landing-zone #889

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

alaincormier-ssc
Copy link
Collaborator

in preparation for feature #883

NOTICE: setters have been modified

  • rename the dns-project-id setter to core-dns-project-id to avoid confusion with the upcoming new dns project in the client-landing-zone

Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@stephanemillaire-ssc stephanemillaire-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ lgtm

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@davelanglois-ssc davelanglois-ssc merged commit a35bac6 into main Mar 12, 2024
3 checks passed
@davelanglois-ssc davelanglois-ssc deleted the gh883-core-landing-zone branch March 12, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants