Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distinct VPC host prep gke-cluster-autopilot BREAKING CHANGE #893

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

alaincormier-ssc
Copy link
Collaborator

BREAKING CHANGE
the firewall policies in this package will only work with the latest "distinct host project" design

in preparation for feature #883

NOTICE: setters have been modified

gke-cluster-autopilot package:

  • firewall policy rules in application-infrastructure-folder/: folder renamed and resources updated to reference (spec.firewallPolicyRef) the proper "classification" policy.
  • refactor setters with a similar approach to client-project-setup, to be able to update references based on classification
  • standardize how networkRef reference a network

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@anoopsidhu-ssc anoopsidhu-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alaincormier-ssc alaincormier-ssc merged commit 2b5ff79 into main Mar 13, 2024
3 checks passed
@alaincormier-ssc alaincormier-ssc deleted the gh883-gke-cluster-autopilot branch March 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants